Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: don't resolve expressions with wildcard types #108892

Merged
merged 1 commit into from
Oct 27, 2023

Commits on Oct 27, 2023

  1. tree: don't resolve expressions with wildcard types

    There are various wildcard types that are used during type-checking,
    but which are not valid during execution. Previously, we only checked
    for `types.Any` in several places, but there are other wildcard types
    like `types.AnyEnum` with similar properties. This could lead to an
    internal panic during execution when this invalid type was resolved.
    This patch adds a new method `types.T.IsWildcardType()` that checks
    for all wildcard types, to be used during type-checking.
    
    Fixes cockroachdb#83496
    
    Release note (bug fix): Fixed a bug that has existed since before v22.2
    which could cause an internal error during distributed execution for an
    expression like `CASE` that requires its inputs to be the same type
    with all `NULL` inputs.
    DrewKimball committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    536ff94 View commit details
    Browse the repository at this point in the history