sql: validate row level ttl schedule for insights tables #108911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds two new system tables to store statements and transaction execution insights. Before, this data was kept in memory only and tracked limited number of latest insights. These tables will be used to persist this data periodically. Tables allow to store the same information as in memory store without aggregation. Tables implement Row level TTL to delete old records. Release note (sql change): added new system.txn_exec_insights and stmt_exec_insights tables to persist execution insights.
This change adds permanent migration to validate and schedule job for row level TTL for system.txn_exec_insights and system.stmt_exec_insights tables. It is necessary because RowLevelTTL for those system tables defined as part of descriptors and isn't started. Release note (sql change): ensure that row level TTL schedule is valid and active for system.txn_exec_insights and system.stmt_exec_insights tables.
koorosh
requested review from
lidorcarmel and
cucaroach
and removed request for
a team
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I have added a few people who may be able to assist in reviewing: 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
blathers-crl
bot
added
O-community
|
This change is |
|
Closed as it is not valid implementation anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds permanent migration to validate and schedule job for
row level TTL for system.txn_exec_insights and system.stmt_exec_insights
tables. It is necessary because RowLevelTTL for those system tables
defined as part of descriptors and isn't started.
Release note (sql change): ensure that row level TTL schedule is
valid and active for
system.txn_exec_insightsandsystem.stmt_exec_insightstables.
Epic: None
Related to: #104582
Created on top of #104714 PR, only last commit should be reviewed.