Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: ui: fix app = empty string filter on stmts page #108985

Merged
merged 1 commit into from Aug 22, 2023
Merged

release-23.1: ui: fix app = empty string filter on stmts page #108985

merged 1 commit into from Aug 22, 2023

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Aug 18, 2023 •
edited

Backport 1/1 commits from #107750
cc @cockroachdb/release

The filter on app name = empty string was not working on the stmts page. This was due to the fact that we use (unset) as the option in the filter to represent selecting the empty string app name. However when filtering statements, the empty string app name on the stmt was not changed accordingly. this commit fixes this and also adds testing for the unset case.

Epic: none
Fixes: #107748

Release note (bug fix): Filter on stmts page works for app name = empty string (represented as 'unset').

Release justification: bug fix

@xinhaoz xinhaoz requested a review from a team as a code owner August 18, 2023 12:03
@blathers-crl
Copy link

blathers-crl bot commented Aug 18, 2023 •
edited by xinhaoz

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz
ui: fix app = empty string filter on stmts page
5e0e699 
The filter on app name = empty string was not working on
the stmts page. This was due to the fact that we use (unset)
as the option in the filter to represent selecting the empty
string app name. However when filtering statements, the empty
string app name on the stmt was not changed accordingly.
this commit fixes this and also adds testing for the unset case.

This commit also adds sql api testing functions to mock stmt
data, which was introduced in cockroachdb#101188.

Epic: none
Fixes: cockroachdb#107748

Release note (bug fix): Filter on stmts page works for
app name = empty string (represented as 'unset').
@xinhaoz xinhaoz requested a review from a team August 22, 2023 08:35
maryliag
maryliag reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR description is missing info such as which PR is being backported

Reviewed all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@xinhaoz
Copy link
Member Author

xinhaoz commented Aug 22, 2023

Done.

maryliag
maryliag approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@xinhaoz xinhaoz merged commit ef5614f into cockroachdb:release-23.1 Aug 22, 2023
6 checks passed
@xinhaoz xinhaoz deleted the backport-23.1-107750 branch August 22, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryliag maryliag maryliag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xinhaoz @cockroach-teamcity @maryliag