concurrency: s/queuedWriters/queuedLockingRequests/g #109454
Conversation
The new name is more apt for what is being stored in this list. No functional change, but I did clean up some commentary here. Epic: none Release note: None
|
This change is |
arulajmani
changed the title
There was a problem hiding this comment.
Reviewed 41 of 41 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
pkg/kv/kvserver/concurrency/lock_table.go line 1510 at r1 (raw file):
// // Non-locking readers are held in a separate list to the list of // waitingReaders, and they make no claims on unheld locks like locking
Is this supposed to say "list of waiting locking requests"? The sentence could be made more clear.
pkg/kv/kvserver/concurrency/lock_table.go line 1577 at r1 (raw file):
// This is a deadlock caused by the lock table unless req2 partially // breaks the claim at A. queuedLockingRequests list.List
This could have also been queuedLockers or queuedLockingReqs if you were looking for something a little more compact, but this works too!
We renamed the receiver when lockState was changed to keyLocks, but we never renamed all references to l.mu. Epic: none Release note: None
arulajmani
force-pushed
the
sl-lock-wait-queue-changes
branch
from
fe8734e
to
3c6df30
Compare
There was a problem hiding this comment.
TFTR!
bors r=nvanbenschoten
Reviewable status:
pkg/kv/kvserver/concurrency/lock_table.go line 1510 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Is this supposed to say "list of waiting locking requests"? The sentence could be made more clear.
Yeah. I simplified this paragraph a bit.
pkg/kv/kvserver/concurrency/lock_table.go line 1577 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
This could have also been
queuedLockersorqueuedLockingReqsif you were looking for something a little more compact, but this works too!
Mild preference for queuedLockingRequests because it rolls off the tongue better when used in comments, so I'll keep it.
|
Build succeeded: |
See individual commits for details.