sql: add VIEWSYSTEMTABLE system privilege #109474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
annrpom
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andyyang890 and @rafiss)
pkg/sql/authorization.go line 274 at r1 (raw file):
// Special case for system tables. The VIEWSYSTEMTABLE system privilege is // equivalent to having SELECT on all system tables. This is because it is not // possible to dybamically grant SELECT privileges system tables, but in the
nit: dynamically
andyyang890
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status:
This privilege is useful for support situations, where an engineer needs to be able to view system tables without having full admin access. Release note (sql change): Added the VIEWSYSTEMTABLE system privilege. Users with this privilege have SELECT privileges for all tables in the system database.
rafiss
force-pushed
the
view-system-table-priv
branch
from
081ff6a
to
a029f65
Compare
rafiss
commented
Aug 25, 2023
There was a problem hiding this comment.
tftr!
bors r+
Reviewable status:
pkg/sql/authorization.go line 274 at r1 (raw file):
Previously, annrpom (annie pompa) wrote…
nit: dynamically
done!
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This privilege is useful for support situations, where an engineer needs to be able to view system tables without having full admin access.
informs #95756
Release note (sql change): Added the VIEWSYSTEMTABLE system privilege. Users with this privilege have SELECT privileges for all tables in the system database.