release-23.1: sql: fix activity update job missing stmts #109479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Problem: The UI was missing query text and details when looking at SQL activity transaction page when there was more than 500 statments or transactions. This is because the activity update job only included the top N statements for each table. It is possible that a transaction is in the top list but none of it's individual statements are. Solution: The activity update job now includes all statements for a transaction that is in the transaction_acitivity table. This was done by adding another query after the initial update to add any missing statements. Fixes: #109200 Release note (sql change): Fixes issue where the UI was missing query text and details when looking at SQL activity transaction page if there was more than 500 transaction or statements. The statement_activity table now includes all statements for a transaction that are in the transaction_activity table.
blathers-crl
bot
requested review from
mgartner
and removed request for
a team
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-109424
branch
from
d850c07
to
4b14133
Compare
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-109424
branch
from
abf305f
to
bbcf4f4
Compare
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
the
backport
|
This change is |
maryliag
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @cucaroach, @gtr, and @mgartner)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #109424 on behalf of @j82w.
/cc @cockroachdb/release
Problem:
The UI was missing query text and details when looking at SQL activity transaction page when there was more than 500 statments or transactions. This is because the activity update job only included the top N statements for each table. It is possible that a transaction is in the top list but none of it's individual statements are.
Solution:
The activity update job now includes all statements for a transaction that is in the transaction_acitivity table. This was done by adding another query after the initial update to add any missing statements.
Fixes: #109200
Release note (sql change): Fixes issue where the UI was missing query text and details when looking at SQL activity transaction page if there was more than 500 transaction or statements. The statement_activity table now includes all statements for a transaction that are in the transaction_activity table.
Release justification: bug fix