builtins: add gen_random_bytes builtin function #110107
Conversation
|
This change is |
There was a problem hiding this comment.
Oh heh you beat me to it. LGTM, just had one small comment!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
pkg/sql/logictest/testdata/logic_test/pgcrypto_builtins line 321 at r1 (raw file):
query I SELECT length(gen_random_bytes(10))
Do we maybe also want to run this query twice, store the results, and then check that they are not identical as a proxy for testing randomness?
Release note (sql change): Added the gen_random_bytes builtin function, which generates cryptographically secure random bytes.
rafiss
force-pushed
the
gen_random_bytes
branch
from
7392473
to
c075f6c
Compare
There was a problem hiding this comment.
tftr!
bors r+
Reviewable status:
pkg/sql/logictest/testdata/logic_test/pgcrypto_builtins line 321 at r1 (raw file):
Previously, andyyang890 (Andy Yang) wrote…
Do we maybe also want to run this query twice, store the results, and then check that they are not identical as a proxy for testing randomness?
done
|
👎 Rejected by too few approved reviews |
|
tftr! bors r+ |
|
Build succeeded: |
fixes #21001
Release note (sql change): Added the gen_random_bytes builtin function, which generates cryptographically secure random bytes.