Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engineccl: skip BenchmarkTimeBoundIterate #110451

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Sep 12, 2023

This benchmark's assertions have recently become flaky.

Epic: none
Informs: #110299
Release note: none

This benchmark's assertions have recently become flaky.

Epic: none
Informs: cockroachdb#110299
Release note: none
@jbowens jbowens requested a review from a team as a code owner September 12, 2023 15:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @bananabrick)

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 12, 2023

TFTR

bors r=RaduBerinde

@craig
Copy link
Contributor

craig bot commented Sep 12, 2023

Build succeeded:

@craig craig bot merged commit 40dd180 into cockroachdb:master Sep 12, 2023
8 checks passed
@jbowens jbowens deleted the skip-BenchmarkTimeBoundIterate branch September 12, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
(Deprecated) Storage
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants