Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: use MAX downsampler for sql connection rate #110497

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 12, 2023

Backport 1/1 commits from #110391 on behalf of @dhartunian.

/cc @cockroachdb/release


Epic: None

Release note (ui change): The "SQL Connection Rate" metric on the SQL Dashboard is downsampled using the MAX function instead of SUM. This improves situations where zooming out would cause the connection rate to increase for downsampled data.


Release justification: tiny adjustment to prevent confusion on DB Console

Epic: None

Release note (ui change): The "SQL Connection Rate" metric on the SQL
Dashboard is downsampled using the MAX function instead of SUM. This
improves situations where zooming out would cause the connection rate
to increase for downsampled data.
@blathers-crl blathers-crl bot requested a review from a team September 12, 2023 19:52
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 12, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110391 branch from 35cfbca to 0607f16 Compare September 12, 2023 19:52
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 12, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 12, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian dhartunian merged commit 464ddd7 into release-23.1 Sep 13, 2023
6 checks passed
@dhartunian dhartunian deleted the blathers/backport-release-23.1-110391 branch September 13, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants