release-23.1: upgrade: remove buggy TTL repair

[ecwall]

Backport 2/2 commits from #110364 and #110816.

/cc @cockroachdb/release

---

Fixes #110363

The TTL descriptor repair in FirstUpgradeFromReleasePrecondition incorrectly
removes TTL fields from table descriptors after incorrectly comparing the
table descriptor's TTL job schedule ID to a set of job IDs.

This change removes the repair until tests are properly added.

Release note (bug fix): Remove buggy TTL descriptor repair. Previously,
upgrading from 22.2.X to 23.1.9 incorrectly removed TTL storage params from
tables (visible via SHOW CREATE TABLE <ttl-table>;) while attempting to
repair table descriptors. This resulted in the node that attempts to run the
TTL job crashing due to a panic caused by the missing TTL storage params.
Clusters currently on 22.2.X should NOT be upgraded to 23.1.9 and should
be upgraded to 23.1.10 or later directly.

Release justification: Backport to base extraordinary release 23.1.10 on.

[blathers-crl]

Thanks for opening a backport.

Please check the backport criteria before merging:

• Patches should only be created for serious issues or test-only changes.
• Patches should not break backwards-compatibility.
• Patches should change as little code as possible.
• Patches should not change on-disk formats or node communication protocols.
• Patches should not add new functionality.
• Patches must not add, edit, or otherwise modify cluster versions; or add version gates.

If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.

• There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
• The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
• New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
• The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

• What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
• Will this work in a cluster of mixed patch versions? Did we test that?
• If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

[cockroach-teamcity]

This change is 

[rafiss]

nit: let's add an additional change to this backport. it should use an environment variable to make this function return early by default:

cockroach/pkg/upgrade/upgrades/first_upgrade.go

Line 38 in f2b6dc7

func FirstUpgradeFromReleasePrecondition(

[rafiss]

in the backport, this should be LIKE '%22.2-%'

[ecwall]

Added

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/sql/logictest/testdata/logic_test/mixed_version_upgrade_repair_descriptors line 11 at r2 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

in the backport, this should be LIKE '%22.2-%'

Done

[rafiss]

nice, lgtm!

[rafiss]

blathers backport 23.1.11-rc

[celiala]

blathers backport staging-v23.1.10