ui: add plan gist as option on bundle collection #110931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
force-pushed
the
gist-modal
branch
2 times, most recently
from
77fab29
to
ca5ef87
Compare
Part Of cockroachdb#103018 This commit adds an option to collect statement bundle based on a specific plan gist. Release note (ui change): Add option to filter out by specific plan gist when collecting a statement bundle.
maryliag
force-pushed
the
gist-modal
branch
from
ca5ef87
to
790cd51
Compare
zachlite
approved these changes
Sep 20, 2023
|
bors r+ |
xinhaoz
reviewed
Sep 20, 2023
| @@ -1021,6 +1021,7 @@ export class StatementDetails extends React.Component< | |||
| onSortingChange={this.props.onSortingChange} | |||
| currentScale={this.props.timeScale} | |||
| onChangeTimeScale={this.changeTimeScale} | |||
| planGists={this.props.statementDetails.statement.stats.plan_gists} | |||
There was a problem hiding this comment.
Is plan_gists always going to exists or do we need to do some optional chaining here?
There was a problem hiding this comment.
always going to exist
| value={selectedPlanGist} | ||
| defaultValue={planGists ? planGists[0] : ""} | ||
| onChange={(selected: string) => | ||
| setSelectedPlanGist(selected) |
There was a problem hiding this comment.
You can skip creating the anon function here and just pass in setSelectedPlanGist since the params line up and there's no extra work.
There was a problem hiding this comment.
I was getting a lint error, because the default is int, so I need to create this way to get the parameter as string
|
bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: There is another option to get any plan except from the selected gist, but that is not part of this PR. Once a design is created, this option can be added.
Part Of #103018
This commit adds an option to collect statement bundle based on a specific plan gist.
https://www.loom.com/share/59335438f0884b75a7d163d96effe5a8
Release note (ui change): Add option to filter out by specific plan gist when collecting a statement bundle.