Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: fix builtin format_type for array types #110940

Merged
merged 1 commit into from Sep 21, 2023
Merged

release-23.1: sql: fix builtin format_type for array types #110940

merged 1 commit into from Sep 21, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 19, 2023 •
edited by rafiss

Backport 1/1 commits from #110900 on behalf of @fqazi.

/cc @cockroachdb/release

Previously, the format_type builtin did not correctly include length information for the contents of an array. So, if we formatted an array of VARCHAR(32) the length would not be included, which leads to an incompatibility with Postgres. This patch passes the typemod information down, formatting the array's contents, which leads to the correct behaviour.

Fixes: #110539

Release note (bug fix): format_type builtin did not honour typemod information for array types, leading to incorrect output.

Release justification: bug fix

@fqazi
sql: fix builtin format_type for array types
843b0e9 
Previously, the format_type builtin did not correctly include length
information for the contents of an array.  So, if we formatted an array
of VARCHAR(32) the length would not be included, which leads to an
incompatibility with Postgres. This patch passes the typemod information
down, formatting the array's contents, which leads to the correct
behaviour.

Fixes: #110539

Release note (bug fix): format_type builtin did not honour
typemod information for array types, leading to incorrect
output.
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 19, 2023 21:20
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110900 branch from 12e412d to 8e89ca0 Compare September 19, 2023 21:20
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 19, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110900 branch from 209894e to 843b0e9 Compare September 19, 2023 21:20
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 19, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 19, 2023
@blathers-crl blathers-crl bot requested a review from rafiss September 19, 2023 21:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi merged commit 5b0f319 into release-23.1 Sep 21, 2023
6 checks passed
@fqazi fqazi deleted the blathers/backport-release-23.1-110900 branch September 21, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

@fqazi fqazi

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @rafiss @fqazi