pg_catalog: populate atttypmod for timestamp/interval types #111400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, the atttypmod was not populated inside the pg_attribute catalog table. This meant that ORM's could not know the precision of these types properly. This patch will add precision to the pg_attribute table and formatting for the interval type to address this. Fixes: cockroachdb#110787 Release note (bug fix): atttypmod in pg_attribute was not populated for timestamp / interval types.
|
@rafiss TFTR! bors r+ |
|
Build succeeded: |
|
For later adventurers, the backport was made in 23.1.13 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the atttypmod was not populated inside the pg_attribute catalog table. This meant that ORM's could not know the precision of these types properly. This patch will add precision to the pg_attribute table and formatting for the interval type to address this.
Fixes: #110787
Release note (bug fix): atttypmod in pg_attribute was not populated for timestamp / interval types.