Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: add check for value #111505

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 29, 2023

Backport 1/1 commits from #111472 on behalf of @maryliag.

/cc @cockroachdb/release


Reading value mean of undefined was causing a crash.

Fixes #107906

Release note (bug fix): Add check for values before using mean on Plan Details page, no longer causing a crash.


Release justification: bug fix

Reading value `mean` of undefined was causing a crash.

Fixes #107906

Release note (bug fix): Add check for values before using `mean` on Plan
Details page, no longer causing a crash.
@blathers-crl blathers-crl bot requested a review from a team September 29, 2023 15:13
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-111472 branch from 9222d58 to 41651d6 Compare September 29, 2023 15:13
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 29, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-111472 branch from 4833976 to 71b9179 Compare September 29, 2023 15:13
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 29, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 29, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested review from koorosh and a team September 29, 2023 16:37
Copy link
Collaborator

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag maryliag merged commit 24b7880 into release-23.1 Sep 29, 2023
6 checks passed
@maryliag maryliag deleted the blathers/backport-release-23.1-111472 branch September 29, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants