backupccl,delegate: change SHOW SCHEDULES columns for schedule options #111759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 23.2 we added two columns to `SHOW SCHEDULES` that surfaces the values for the schedule options corresponding to `on_previous_running` and `on_execution_failure`. These column names were previously named `on_wait` and `on_error` since those were the internal proto names. It makes more sense to align these with the publically documented option names. Release note (sql change): `SHOW SCHEDULES` has two columns that surface the schedule options. These columns have been renamed to align with the documented option names namely `on_previous_running` and `on_execution_failure`.
|
This change is |
msbutler
approved these changes
Oct 4, 2023
|
flakes seems unrelated bors r=msbutler |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 23.2 we added two columns to
SHOW SCHEDULESthat surfaces the values for the schedule options corresponding toon_previous_runningandon_execution_failure. These column names were previously namedon_waitandon_errorsince those were the internal proto names. It makes more sense to align these with the publically documented option names.Epic: none
Release note (sql change):
SHOW SCHEDULEShas two columns that surface the schedule options. These columns have been renamed to align with the documented option names namelyon_previous_runningandon_execution_failure.