cli: remove redundant hex_ columns in debug.zip output #112033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
cucaroach
changed the title
cucaroach
force-pushed
the
no_hex
branch
2 times, most recently
from
b527a6b
to
8a59b87
Compare
dhartunian
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
In cockroachdb#80398 we fixed the CLI to respect bytea_output session variable and properly output BYTES columns in \xDEADBEEF format. Now we don't need the extra hex_ columns. This makes debug.zips smaller and quicker to create (jobs payloads can get big and so can descriptors for large tables). In order not to break cockroach debug decode-proto extend it to look for and remove the \x prefix when attempting to decode hex. Fixes: cockroachdb#112032 Epic: none Release note (cli change): debug zip's no longer include redundant hex_ columns for system table BYTES columns.
|
bors r- |
|
bors r+ |
|
Build succeeded: |
|
TFTR! bors r+ |
|
Already running a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #80398 we fixed the CLI to respect bytea_output
session variable and properly output BYTES columns in \xDEADBEEF format.
Now we don't need the extra hex_ columns. This makes debug.zips smaller
and quicker to create (jobs payloads can get big and so can descriptors
for large tables).
In order not to break cockroach debug decode-proto extend it to look
for and remove the \x prefix when attempting to decode hex.
Fixes: #112032
Epic: none
Release note (cli change): debug zip's no longer include redundant hex_
columns for system table BYTES columns.