Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: clarify comments/naming of descriptorChanged flag #112698

Merged
merged 1 commit into from Oct 20, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Oct 19, 2023

fixes #110727
Release note: None

@rafiss rafiss requested a review from Xiang-Gu October 19, 2023 16:47
@rafiss rafiss requested a review from a team as a code owner October 19, 2023 16:47
@blathers-crl
Copy link

blathers-crl bot commented Oct 19, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented Oct 20, 2023

tftr!

bors r+

@craig craig bot merged commit 48baa96 into cockroachdb:master Oct 20, 2023
7 of 8 checks passed
@craig
Copy link
Contributor

craig bot commented Oct 20, 2023

Build succeeded:

@rafiss rafiss deleted the clarify-ttl-desc-changed branch October 20, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ttl: handleTTLStorageParamChange might return incorrect descriptorChanged value
3 participants