sql: make tests error if a leaf txn is not created when expected #112726
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)
pkg/sql/distsql_running.go line 899 at r1 (raw file):
return } if buildutil.CrdbTestBuild && txn != nil && localState.MustUseLeaf && flow.GetFlowCtx().Txn.Type() != kv.LeafTxn {
I think localState.MustUseLeaf is a function.
This adds a test-only error if a leaf transaction is expected to be used by a plan but a root transaction is used instead. Epic: none Informs: cockroachdb#111097 Release note: None
rharding6373
force-pushed
the
20231011_udf_concurrent_txn_pt2_111097
branch
from
2ef4e54
to
a40a557
Compare
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/distsql_running.go line 899 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
I think
localState.MustUseLeafis a function.
It's a bool, but I suppose it wouldn't hurt to change this check to use the function, so I've done so.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
pkg/sql/distsql_running.go line 899 at r1 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
It's a bool, but I suppose it wouldn't hurt to change this check to use the function, so I've done so.
Oh, right, I was thinking about localState.MustUseLeafTxn().
|
bors r+ |
|
Build succeeded: |
This adds a test-only error if a leaf transaction is expected to be used by a plan but a root transaction is used instead.
Epic: none
Informs: #111097
Release note: None