sql: make jsonb_array_to_string_array return NULL elements
#112975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryliag
requested review from
a team and
mgartner
and removed request for
a team
|
This change is |
This was referenced Oct 24, 2023
|
friendly ping @mgartner |
yuzefovich
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @mgartner)
-- commits line 12 at r1:
nit: I'd reword this to something like "The newly added builting jsonb_array_to_string_array no longer removes NULL objects and includes them into the resulting array."
This commit makes the builtin `jsonb_array_to_string_array` return NULL elements, which were previously being removed. It also adds more testing for different types of elements on the array. Followup from cockroachdb#112865 (review) Epic: none Release note (sql change): The newly added builtin `jsonb_array_to_string_array` no longer removes NULL objects and includes them into the resulting array.
maryliag
force-pushed
the
improve-json-array-builtin
branch
from
665649f
to
acbd14f
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
|
Thanks for fixing this! Sorry I was so slow to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the builtin
jsonb_array_to_string_arrayreturn NULL elements, which were previously being removed. It also adds more testing for different types of elements on the array.Followup from #112865 (review)
Epic: none
Release note (sql change): The newly added builting jsonb_array_to_string_array no longer removes NULL objects and includes them into the resulting array.