New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: kvserver: gate writing the new sticky GCHint #113040
Conversation
StateLoader.SetGCHint returns true iff err == nil. We can safely remove the bool return value. Epic: none Release note: none
Since it is late to enable this behaviour in 23.1 (risk of backwards incompatibility), hide it behind a default-off cluster setting. In 23.2, it will be enabled by default, and the cluster setting will be deprecated. The new GCHint behaviour is likely backwards compatible, but we are hiding it behind a setting for extra safety. The safest moment to enable this cluster setting is when there is some confidence that the cluster binaries will not rollback to previous patch versions of 23.1. The risk exists only in mixed-version state in which some 23.1 binaries don't know the new GCHint fields, and some do. Epic: none Release note (ops change): introduce a default-off cluster setting `kv.gc.sticky_hint.enabled` which helps expediting garbage collection after range deletions, such as when a SQL table or index is dropped.
Epic: none Release note (general change): set the default behaviour for `kv.gc.sticky_hint.enabled` cluster setting to enabled since 23.2. The setting is deprecated in 23.2 going forward.
aab9af1
to
b12ea10
Compare
3a423a8
to
829cb6d
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
do we need the setting for this one? can we default on for 23.2 with an IsActive(V_23_2) version gate instead? |
We do, the setting is there to respect it in mixed-version clusters until the upgrade finalizes. |
Backport 3/3 commits from #112948 on behalf of @pavelkalinnikov.
/cc @cockroachdb/release
This PR makes the new behaviour of
GCHint
introduced in #110078 conditional on a default-off cluster setting in 23.1, and enabled in 23.2 by a version gate.Since it is late to enable this behaviour in 23.1 (risk of backwards incompatibility), hide it behind a default-off cluster setting. In 23.2, it will be enabled by default, and the cluster setting will be deprecated.
The new
GCHint
behaviour is likely backwards compatible, but we are hiding it behind a setting for extra safety.The safest moment to enable this cluster setting is when there is some confidence that the cluster binaries will not rollback to previous patch versions of 23.1. The risk exists only in mixed-version state in which some 23.1 binaries don't know the new
GCHint
fields, and some do.Epic: none
Release note (ops change): introduce a default-off cluster setting
kv.gc.sticky_hint.enabled
which helps expediting garbage collection after range deletions, such as when a SQL table or index is dropped.Release note (general change): set the default behaviour for
kv.gc.sticky_hint.enabled
cluster setting to enabled since 23.2. The setting is deprecated in 23.2 going forward.Release justification: safety net for a critical bug fix