Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: jobs: fix bug in WriteChunkedFileToJobInfo during overwriting #113290

Merged
merged 1 commit into from Oct 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 30, 2023

Backport 1/1 commits from #113241 on behalf of @adityamaru.

/cc @cockroachdb/release


Previously, WriteChunkedFileToJobInfo would chunk up the passed in byte slice and write the chunks to the job_info table with info keys constructed using the filename. If the method were to be invoked again with the same filename, due to the delete before write semantics of the job info table, if the number of chunks changed then we'd end up with a corrupt file. With chunks from the first and second write mixed.

This change fixes the bug by first deleting all the chunks that correspond to the filename before writing the new data. This is in line with how you'd expect an overwrite operation to work. This change also adds a regression test for the same.

Fixes: #113232
Release note (bug fix): fixes a bug in a method that was used by some of the jobs observability infrastructure, that could be triggered if a file was overwrriten with a different chunking strategy


Release justification: bug fix for jobs observability features that are new to 23.2

Previously, `WriteChunkedFileToJobInfo` would chunk up the
passed in byte slice and write the chunks to the job_info table
with info keys constructed using the filename. If the method
were to be invoked again with the same filename, due to the
delete before write semantics of the job info table, if the
number of chunks changed then we'd end up with a corrupt
file. With chunks from the first and second write mixed.

This change fixes the bug by first deleting all the chunks that
correspond to the filename before writing the new data. This
is in line with how you'd expect an overwrite operation to
work. This change also adds a regression test for the same.

Fixes: #113232
Release note (bug fix): fixes a bug in a method that was used
by some of the jobs observability infrastructure, that could be
triggered if a file was overwrriten with a different chunking
strategy
@blathers-crl blathers-crl bot requested review from a team as code owners October 30, 2023 14:41
@blathers-crl blathers-crl bot requested review from msbutler and removed request for a team October 30, 2023 14:41
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 30, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113241 branch 2 times, most recently from 8e1e19c to f52410d Compare October 30, 2023 14:41
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from dt and stevendanna October 30, 2023 14:41
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor

flake is being tracked #112763

@adityamaru adityamaru merged commit 83ae695 into release-23.2 Oct 30, 2023
5 of 6 checks passed
@adityamaru adityamaru deleted the blathers/backport-release-23.2-113241 branch October 30, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants