Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obsservice: export StatementInsightsStatistics #113498

Merged
merged 2 commits into from
Nov 6, 2023
Merged

obsservice: export StatementInsightsStatistics #113498

merged 2 commits into from
Nov 6, 2023

Commits on Nov 1, 2023

  1. obsservice: add stmt insights proto and conversion 

    Add proto definition for Statement Insights to be
used on Obs Service.
Creates function to copy a `insights.Statement` to the new
`obspb.StatementInsightsStatistics` format.

For this version, there are some parameters not being set,
such as contention. Those will be populated on a following
iteration.

Epic: none

Release note: None
    @maryliag
    maryliag committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    02b3a9a View commit details
    Browse the repository at this point in the history

  2. obsservice: export StatementInsightsStatistics 

    This patch hooks into the Flush functionality used
by PersistedSQLStats, in preparation for Insights
to be sent to external o11y systems.
A following PR will do the actual export during the flush.

Lastly, it's acknowledged that the transformation
required here is likely going to be heavy on
allocations. During the prototyping phase however,
we leave the optimization and/or restructuring of
the exported type for the future. For now, we use
a sync.Pool in an effort to reduce allocations/GC.

Release note: none
    @maryliag
    maryliag committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c4d59bb View commit details
    Browse the repository at this point in the history