New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: sql/schemachanger: apply admission control to merge phase of backfill #113725
Conversation
Previously, when merging indexes as a part of our MVCC-compliant protocol, we did not properly flag the writes with the correct priority. As a result, on certain workloads, creating a secondary index could tank performance. To address this, this patch will set the priority for the writes during the merge phase of the backfill protocol. Fixes: #113705 Release note (performance): Address performance regression that can happen when the declarative schema changer is being used to creating an index with a concurrent workload.
ef4b0db
to
1b7a8eb
Compare
26def21
to
6fdf6b1
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Backport 1/1 commits from #113713 on behalf of @fqazi.
/cc @cockroachdb/release
Previously, when merging indexes as a part of our MVCC-compliant protocol, we did not properly flag the writes with the correct priority. As a result, on certain workloads, creating a secondary index could tank performance. To address this, this patch will set the priority for the writes during the merge phase of the backfill protocol.
Fixes: #113705
Release note (performance): Address performance regression that can
happen when the declarative schema changer is being used to create an
index with a concurrent workload.
Release justification: high priority bug fix