jobs: only force jobs.MaybeGenerateForcedRetryableError in 23.1 #113864
Conversation
dt
requested review from
miretskiy,
abarganier and
yuzefovich
and removed request for
a team
|
This change is |
dt
force-pushed
the
cv-info
branch
2 times, most recently
from
e3b51d8
to
f643bc6
Compare
This is a pure refactor to plumb a clusterversion.Handle to the info table accessor via all the call sites and wrapping structs/call trees; no behavior change, or usage of the plumbed cv, is added in this commit. Release note: none. Epic: none.
Release note (bug fix): fixed a bug that could cause 23.1 nodes in clusters which had not finalized the 23.1 version upgrade to use excessive CPU retrying expected errors related to the incomplete upgrade state.
Release note: none. Epic: none.
dt
added
backport-23.1.x
|
TFTRs! bors r+ |
|
Build succeeded: |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 881576e to blathers/backport-release-23.1-113864: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. error creating merge commit from 881576e to blathers/backport-release-23.1.12-rc.FROZEN-113864: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.12-rc.FROZEN failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
114069: jobs: remove jobs.MaybeGenerateForcedRetryableError r=dt a=dt Revert 3/3 commits from #113864 and then delete jobs.MaybeGenerateForcedRetryableError since it is not needed on master as master (24.1) will never run the 22.2 to 23.1 upgrade. Epic: none. Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Broken into a couple commits for ease of review:
This is a pure refactor to plumb a clusterversion.Handle to the info table accessor
via all the call sites and wrapping structs/call trees; no behavior change, or usage
of the plumbed cv, is added in this commit.
jobs: only force jobs.MaybeGenerateForcedRetryableError in 23.1
jobs: only store 23.1 debugging info after 23.1 upgrade
Release note (bug fix): fixed a bug that could cause 23.1 nodes in clusters which had not finalized the 23.1
version upgrade to use excessive CPU retrying expected errors related to the incomplete upgrade state.
Informs #113795.