cli: remove cockroach connect #113893
Merged
cli: remove cockroach connect #113893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
andrewbaptist
force-pushed
the
2023-11-06-remove-auto-init
branch
2 times, most recently
from
889a42d
to
94b4fe7
Compare
This was referenced Nov 9, 2023
`connect` was implemented as an experiment to allow bootstrapping nodes from other nodes CA's. The details are described here: https://github.com/aaron-crl/toy-secure-init-handshake/tree/n-way-join This implementation was never completed, and the visibility of this code can cause confusion. This PR removes all the code with the idea that we can bring it back later if necessary. Epic: none Release note (cli change): Removal of the `cockroach connect` functionality.
andrewbaptist
force-pushed
the
2023-11-06-remove-auto-init
branch
from
94b4fe7
to
ad4350a
Compare
andrewbaptist
requested review from
abarganier and
nvanbenschoten
and removed request for
a team
nvanbenschoten
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @abarganier)
|
bors r=nvanbenschoten TFTR |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectwas implemented as an experiment to allow bootstrapping nodes from other nodes CA's (#60632). The details are described here: https://github.com/aaron-crl/toy-secure-init-handshake/tree/n-way-joinThis implementation was never completed, and the visibility of this code can cause confusion. This PR removes all the code with the idea that we can bring it back later if necessary.
Epic: none
Release note (cli change): Removal of the
cockroach connectfunctionality.