Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: kvclient: stop reads on followers #114259

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 10, 2023

Backport 1/1 commits from #114205 on behalf of @andrewbaptist.

/cc @cockroachdb/release


Stop follower reads on draining, decommissioning or unhealthy nodes.

Epic: none
Fixes: #112351

Release note (performance improvement): This change prevents failed requests from being issued on followers that are draining, decommissioning or unhealthy which prevents latency spikes if those nodes later go offline.


Release justification: Customer has asked for this functionality. It is disabled by default and only impacts customers who enable it.

Stop follower reads on draining, decommissioning or unhealthy nodes.

Epic: none
Fixes: #112351

Release note (performance improvement): This change prevents failed
requests from being issued on followers that are draining,
decommissioning or unhealthy which prevents latency spikes if those
nodes later go offline.
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 10, 2023 20:06
@blathers-crl blathers-crl bot requested a review from a team November 10, 2023 20:06
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 10, 2023 20:06
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-114205 branch from 94347d4 to c28b86b Compare November 10, 2023 20:06
@blathers-crl blathers-crl bot requested review from mgartner and removed request for a team November 10, 2023 20:06
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 10, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-114205 branch from 608e472 to 1a55b6d Compare November 10, 2023 20:06
Copy link
Author

blathers-crl bot commented Nov 10, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 10, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist andrewbaptist merged commit 495a09b into release-23.2 Nov 11, 2023
5 of 6 checks passed
@andrewbaptist andrewbaptist deleted the blathers/backport-release-23.2-114205 branch November 11, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants