Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvclient: stop reads on followers #114367

Merged

Conversation

andrewbaptist
Copy link
Collaborator

@andrewbaptist andrewbaptist commented Nov 13, 2023

Backport 1/1 commits from #114205.

/cc @cockroachdb/release


Stop follower reads on draining, decommissioning or unhealthy nodes.

Epic: none
Fixes: #112351

Release note (performance improvement): This change prevents failed requests from being issued on followers that are draining, decommissioning or unhealthy which prevents latency spikes if those nodes later go offline.

Release justification: Customer has asked for this functionality. It is disabled by default and only impacts customers who enable it.

@andrewbaptist andrewbaptist requested review from a team as code owners November 13, 2023 19:59
@andrewbaptist andrewbaptist requested review from mgartner and removed request for a team November 13, 2023 19:59
Copy link

blathers-crl bot commented Nov 13, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 13, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Stop follower reads on draining, decommissioning or unhealthy nodes.

Epic: none
Fixes: cockroachdb#112351

Release note (performance improvement): This change prevents failed
requests from being issued on followers that are draining,
decommissioning or unhealthy which prevents latency spikes if those
nodes later go offline.
Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@andrewbaptist andrewbaptist merged commit 24b85a5 into cockroachdb:release-23.1 Nov 14, 2023
6 checks passed
@andrewbaptist andrewbaptist deleted the backport23.1-114205 branch November 14, 2023 19:01
@andrewbaptist andrewbaptist restored the backport23.1-114205 branch December 15, 2023 21:24
@andrewbaptist andrewbaptist deleted the backport23.1-114205 branch December 15, 2023 21:34
@andrewbaptist andrewbaptist restored the backport23.1-114205 branch December 21, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants