New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: kvclient: stop reads on followers #114367
release-23.1: kvclient: stop reads on followers #114367
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
e21c546
to
70d8382
Compare
Stop follower reads on draining, decommissioning or unhealthy nodes. Epic: none Fixes: cockroachdb#112351 Release note (performance improvement): This change prevents failed requests from being issued on followers that are draining, decommissioning or unhealthy which prevents latency spikes if those nodes later go offline.
70d8382
to
535a228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Backport 1/1 commits from #114205.
/cc @cockroachdb/release
Stop follower reads on draining, decommissioning or unhealthy nodes.
Epic: none
Fixes: #112351
Release note (performance improvement): This change prevents failed requests from being issued on followers that are draining, decommissioning or unhealthy which prevents latency spikes if those nodes later go offline.
Release justification: Customer has asked for this functionality. It is disabled by default and only impacts customers who enable it.