Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: do not require system table privileges to use SHOW STATISTICS #114479

Merged
merged 1 commit into from Nov 15, 2023
Merged

release-23.1: sql: do not require system table privileges to use SHOW STATISTICS #114479

merged 1 commit into from Nov 15, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 15, 2023 •
edited

Backport 1/1 commits from #114166.

/cc @cockroachdb/release

Release justification: serious bug fix

See the docs at: https://www.cockroachlabs.com/docs/stable/show-statistics
They say that no special privileges are needed.

Epic: None

Release note (bug fix): The SHOW STATISTICS command previously incorrectly
required the user to have the admin role. It was intended to only
require the user to have any privilege on the table being inspected.
This is now fixed.

@rafiss
sql: do not require system table privileges to use SHOW STATISTICS
a709e77 
See the docs at: https://www.cockroachlabs.com/docs/stable/show-statistics
They say that no special privileges are needed.

Release note (bug fix): The SHOW STATISTICS command previously incorrectly
required the user to have the admin role. It was intended to only
require the user to have any privilege on the table being inspected.
This is now fixed.
@rafiss rafiss requested review from rharding6373, Xiang-Gu and a team November 15, 2023 06:01
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 15, 2023 •
edited by rafiss

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 15, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

michae2
michae2 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rharding6373 and @Xiang-Gu)

@rafiss rafiss merged commit 470b529 into cockroachdb:release-23.1 Nov 15, 2023
6 checks passed
@rafiss rafiss deleted the backport23.1-114166 branch November 16, 2023 22:06
mgartner
mgartner reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

pkg/sql/explain_bundle_test.go
@@ -348,16 +348,17 @@ CREATE TABLE users(id UUID DEFAULT gen_random_uuid() PRIMARY KEY, promo_id INT R
defer r.Exec(t, "SET ROLE root")
r.Exec(t, "CREATE TABLE permissions (k PRIMARY KEY) AS SELECT 1")
rows := r.QueryStr(t, "EXPLAIN ANALYZE (DEBUG) SELECT * FROM permissions")
// Check that we see two errors about missing privileges as warnings
// (one for the cluster settings and another for the table statistics).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bummer that we wrote this without understanding the implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner left review comments

@michae2 michae2 michae2 approved these changes

@rharding6373 rharding6373 Awaiting requested review from rharding6373

@Xiang-Gu Xiang-Gu Awaiting requested review from Xiang-Gu

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rafiss @cockroach-teamcity @mgartner @michae2