sql: fix LSC that incorrectly missed secondary index rewrite during ALTER PK #114622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…LTER PK Fixes cockroachdb#114436 Release note (bug fix): Previously, when set `use_declarative_schema_changer=off` and we attempt to alter primary key on a table that has unique secondary indexes on new-pk-cols, the unique secondary index would incorrectly still have old-pk-cols as its keySuffixColumn after the ALTER PK. This is problematic because a subsequent dropping of the old-pk-cols would unexpectedly drop those unique secondary indexes as well, even without CASCADE. This commit fixes that.
Xiang-Gu
force-pushed
the
bug/alter-pk-legacy-rowid-and-unique-index
branch
from
5eb6168
to
8f293f6
Compare
fqazi
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114436
Release note (bug fix): Previously, when set
use_declarative_schema_changer=offand we attempt to alter primary key on a table that has unique secondary
indexes on new-pk-cols, the unique secondary index would incorrectly
still have old-pk-cols as its keySuffixColumn after the ALTER PK. This
is problematic because a subsequent dropping of the old-pk-cols would
unexpectedly drop those unique secondary indexes as well, even without
CASCADE. This commit fixes that.