-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stress: tweak args for deadlock
and race
nightlies
#114681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2571c5e
to
98da0ee
Compare
On the EngFlow cluster, we would like to take advantage of `race` without disabling sharding, so updating this configuration is sensible. Anywhere where it's useful to disable sharding, we do it inline. Epic: CRDB-8308 Release note: None
Increase timeouts, reduce the number of test runs, unset GITHUB_API_TOKEN for nightlies that aren't working fully yet. Also set `GOTRACEBACK=all` for all EngFlow tests. Epic: CRDB-8308 Release note: None
98da0ee
to
26607ed
Compare
deadlock
and race
nightliesdeadlock
and race
nightlies
Ignore the first commit which is from #115180. |
jlinder
approved these changes
Nov 28, 2023
bors r=jlinder |
Build succeeded: |
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Dec 4, 2023
This change was made accidentally in cockroachdb#114681. Epic: CRDB-8308 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
115535: changefeedccl: redact user-sensitive info from SHOW JOBS output r=jayshrivastava a=wenyihu6 Previously, `SHOW CHANGEFEED JOB` revealed sensitive user data like `api_secret` for confluent cloud sinks. This patch now redacts `api_secret`, `sasl_password`, `client_cert`, and `ca_cert` in the job description and sinkURI output column. Fixes: #113503 Release note (enterprise change): SHOW CHANGEFEED JOB, SHOW CHANGEFEED JOBS, and SHOW JOBS no longer expose user sensitive infromation(`api_secret`, `sasl_password`, `client_cert`, and `ca_cert`) in the job description and sinkURI output column would reveal sensitive user information (api_secret, sasl_password, client_cert, ca_cert). 115554: schemafeed: bump size of test r=rail a=rickystewart This timed out in CI. https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsGcpLinuxX8664BigVm_CclUnitTests/12973040?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildDeploymentsSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true Epic: none Release note: None 115557: stress: re-set GITHUB_API_TOKEN r=rail a=rickystewart This change was made accidentally in #114681. Epic: CRDB-8308 Release note: None Co-authored-by: Wenyi Hu <wenyi@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase timeouts, reduce the number of test runs, unset
GITHUB_API_TOKEN for nightlies that aren't working fully yet.
Also set
GOTRACEBACK=all
for all EngFlow tests.Epic: CRDB-8308
Release note: None