Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stress: tweak args for deadlock and race nightlies #114681

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Nov 17, 2023

Increase timeouts, reduce the number of test runs, unset
GITHUB_API_TOKEN for nightlies that aren't working fully yet.

Also set GOTRACEBACK=all for all EngFlow tests.

Epic: CRDB-8308
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

On the EngFlow cluster, we would like to take advantage of `race`
without disabling sharding, so updating this configuration is sensible.
Anywhere where it's useful to disable sharding, we do it inline.

Epic: CRDB-8308
Release note: None
Increase timeouts, reduce the number of test runs, unset
GITHUB_API_TOKEN for nightlies that aren't working fully yet.

Also set `GOTRACEBACK=all` for all EngFlow tests.

Epic: CRDB-8308
Release note: None
@rickystewart rickystewart changed the title [WIP] stress: tweak args for deadlock and race nightlies stress: tweak args for deadlock and race nightlies Nov 28, 2023
@rickystewart
Copy link
Collaborator Author

Ignore the first commit which is from #115180.

@rickystewart rickystewart marked this pull request as ready for review November 28, 2023 17:58
@rickystewart rickystewart requested a review from a team as a code owner November 28, 2023 17:58
@rickystewart
Copy link
Collaborator Author

bors r=jlinder

@craig
Copy link
Contributor

craig bot commented Nov 28, 2023

Build succeeded:

@craig craig bot merged commit e52d74c into cockroachdb:master Nov 28, 2023
8 checks passed
rickystewart added a commit to rickystewart/cockroach that referenced this pull request Dec 4, 2023
This change was made accidentally in cockroachdb#114681.

Epic: CRDB-8308
Release note: None
craig bot pushed a commit that referenced this pull request Dec 4, 2023
115535: changefeedccl: redact user-sensitive info from SHOW JOBS output r=jayshrivastava a=wenyihu6

Previously, `SHOW CHANGEFEED JOB` revealed sensitive user data like `api_secret`
for confluent cloud sinks. This patch now redacts `api_secret`, `sasl_password`,
`client_cert`, and `ca_cert` in the job description and sinkURI output column.

Fixes: #113503

Release note (enterprise change): SHOW CHANGEFEED JOB,  SHOW CHANGEFEED JOBS,
and SHOW JOBS no longer expose user sensitive infromation(`api_secret`,
`sasl_password`, `client_cert`, and `ca_cert`) in the job description and
sinkURI output column would reveal sensitive user information (api_secret,
sasl_password, client_cert, ca_cert).


115554: schemafeed: bump size of test r=rail a=rickystewart

This timed out in CI.

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsGcpLinuxX8664BigVm_CclUnitTests/12973040?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildDeploymentsSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

Epic: none
Release note: None

115557: stress: re-set GITHUB_API_TOKEN r=rail a=rickystewart

This change was made accidentally in #114681.

Epic: CRDB-8308
Release note: None

Co-authored-by: Wenyi Hu <wenyi@cockroachlabs.com>
Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants