opt: generate constrained scans for indexed, boolean expressions #114798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DrewKimball
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
pkg/sql/opt/idxconstraint/testdata/computed line 43 at r1 (raw file):
---- [/false - /false]
Can you also add an optimizer test to show a constrained scan being generated?
mgartner
force-pushed
the
114078-boolean-indexed-expressions
branch
from
0045bab
to
971ddbe
Compare
mgartner
commented
Jan 4, 2024
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/idxconstraint/testdata/computed line 43 at r1 (raw file):
Previously, DrewKimball (Drew Kimball) wrote…
Can you also add an optimizer test to show a constrained scan being generated?
Done.
Prior to this commit, the optimizer would not generate constrained scans for all indexed, boolean computed expressions. This limitation has been lifted. Fixes cockroachdb#114078 Release note (performance improvement): The optimizer now generates constrained scans on indexes containing boolean, computed expressions.
mgartner
force-pushed
the
114078-boolean-indexed-expressions
branch
from
971ddbe
to
83aa7b6
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the optimizer would not generate constrained scans
for all indexed, boolean computed expressions. This limitation has been
lifted.
Fixes #114078
Release note (performance improvement): The optimizer now generates
constrained scans on indexes containing boolean, computed expressions.