obsservice: creating Insights Pipeline #114802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an Insights is detected, we store it in memory and also export it to Observability Service. This behaviour is controlled by a new cluster setting `sql.insights.export.enabled`. If the value is disabled, no data is exported. Epic: CC-25978 Release note: None
|
This change is |
abarganier
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Looks good! Getting boilerplate stuff merged to demonstrate how everything is glued together is valuable 🎉
I think we just need to fix a couple tests for the mem queue, since we altered the SizeFn signature to no longer return an error. Otherwise LGTM!
Reviewable status:
complete! 0 of 0 LGTMs obtained
maryliag
force-pushed
the
persist-data
branch
from
21d61e3
to
7747d25
Compare
Create basic structure for Insights Pipeline. Currently the Validator (always return that is valid) and Processor (just printing the value) are very simple. This commit is to introduce that structure so can be iterated on. Part Of CC-26215 Release note: None
maryliag
force-pushed
the
persist-data
branch
from
7747d25
to
9581fb1
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to Reviewers: only last commit is relevant to this PR
Create basic structure for Insights Pipeline.
Currently the Validator (always return that is valid)
and Processor (just printing the value) are very simple.
This commit is to introduce that structure so can be iterated on.
https://www.loom.com/share/b568f514753542d9bd5e551b530f917d
Part Of CC-26215
Release note: None