Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: upgrade: use high priority txn's to update the cluster version #115034

Merged
merged 2 commits into from Nov 29, 2023
Merged

release-23.2: upgrade: use high priority txn's to update the cluster version #115034

merged 2 commits into from Nov 29, 2023

Commits on Nov 28, 2023

  1. settingswatcher: add code for encoding system.setting rows 

    To be able to have minimal high priority txns for bumping cluster
version, we need the ability to write the setting table using KV calls.
This patch adds, the functions EncodeSettingKey and EncodeSettingValue
to allow directly generate values for Put/Get calls.

Release note: None
    @fqazi
    fqazi committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ad9104a View commit details
    Browse the repository at this point in the history

  2. upgrade: use high priority txn's to update the cluster version 

    Previously, it was possible for the leasing subsystem to starve out
attempts to set the cluster version during upgrades, since the leasing
subsystem uses high priority txn for renewals. To address this, this
patch makes the logic to set the cluster version high priority so
it can't be pushed out by lease renewals.

Fixes: cockroachdb#113908

Release note (bug fix): Addressed a bug that could cause cluster version
finalization to get starved out by descriptor lease renewals on larger
clusters.
    @fqazi
    fqazi committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    39cb48d View commit details
    Browse the repository at this point in the history