Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: tree: do not elide cast during type checking for placeholders #115132

Merged
merged 1 commit into from
Nov 28, 2023
Merged

release-23.2: tree: do not elide cast during type checking for placeholders #115132

merged 1 commit into from
Nov 28, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 27, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #115013 on behalf of @rafiss.

/cc @cockroachdb/release

Keeping the cast allows the type checker to resolve the placeholder correctly, since the cast contains information that hints the placeholder type.

fixes #114867

Release note (bug fix): Fixed a bug that would cause a prepared statement to fail if it referenced an enum as well as a table that has undergone a schema change.

Release justification: low risk bug fix reported by a customer and ORM partner.

@blathers-crl blathers-crl bot requested review from a team as code owners November 27, 2023 20:55
@blathers-crl blathers-crl bot requested review from mgartner and removed request for a team November 27, 2023 20:55
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 27, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115013 branch 2 times, most recently from 16c0bdf to a8071de Compare November 27, 2023 20:55
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Nov 27, 2023 •
edited by rafiss
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 27, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

yuzefovich
yuzefovich approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner)

@rafiss rafiss force-pushed the blathers/backport-release-23.2-115013 branch from a8071de to 9fe21c7 Compare November 28, 2023 17:44
@rafiss
tree: do not elide cast during type checking for placeholders
f3b6abf 
Keeping the cast allows the type checker to resolve the placeholder
correctly, since the cast contains information that hints the
placeholder type.

Release note (bug fix): Fixed a bug that would cause a prepared
statement to fail if it referenced an enum as well as a table that has
undergone a schema change.
@rafiss rafiss force-pushed the blathers/backport-release-23.2-115013 branch from 9fe21c7 to f3b6abf Compare November 28, 2023 21:08
mgartner
mgartner approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

@rafiss rafiss merged commit 28e0cc2 into release-23.2 Nov 28, 2023
5 of 6 checks passed
@rafiss rafiss deleted the blathers/backport-release-23.2-115013 branch November 28, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@yuzefovich yuzefovich yuzefovich approved these changes

Assignees

@rafiss rafiss

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cockroach-teamcity @mgartner @yuzefovich @rafiss