Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: ui: fix timezone formatting for bar charts #115220

Merged
merged 1 commit into from Nov 29, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 29, 2023

Backport 1/1 commits from #115162 on behalf of @koorosh.

/cc @cockroachdb/release


This change:

  1. Fixes naming of UTC timezone that can be consumed by moment.js (more details: The special area of "Etc" is used for some administrative zones, particularly for "Etc/UTC" which represents Coordinated Universal Time (https://en.wikipedia.org/wiki/Tz_database#Area).
  2. Propagate timezone property to calculateXAxisDomainBarChart func from barchart graph.

Epic: None

Release note (ui change): time on X-Axis of bar charts on Statement details page display correctly formatted time in UTC.

Resolves: #115091

After fix: both tooltip and X-Axis show time in UTC.
Screenshot 2023-11-28 at 16 39 35


Release justification: low risk, high benefit changes to existing functionality

This change:
1. Fixes naming of UTC timezone that can be consumed by moment.js (more details:
The special area of "Etc" is used for some administrative zones, particularly for "Etc/UTC" which represents Coordinated Universal Time (https://en.wikipedia.org/wiki/Tz_database#Area).
2. Propagate `timezone` property to `calculateXAxisDomainBarChart` func from barchart graph.

Epic: None

Release note (ui change): time on X-Axis of bar charts on Statement details page
display correctly formatted time in UTC.
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 29, 2023 00:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115162 branch from d4d7f08 to c35cebe Compare November 29, 2023 00:56
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 29, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115162 branch from 0b4cfa7 to 13283c0 Compare November 29, 2023 00:57
@blathers-crl blathers-crl bot requested a review from maryliag November 29, 2023 00:57
Copy link
Author

blathers-crl bot commented Nov 29, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 29, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh merged commit 84c8ed4 into release-23.2 Nov 29, 2023
5 of 6 checks passed
@koorosh koorosh deleted the blathers/backport-release-23.2-115162 branch November 29, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants