release-23.2: streamingccl: replace replication lag metric with a replicated time metric #115234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #115205 on behalf of @msbutler.
/cc @cockroachdb/release
This patch removes the replication lag metric and dbconsole graph as it's wrong
if more than one replication stream is running, if the job coordinator moves,
or if the job is paused.
This patch adds the
physical_replication.replicated_time_seconds
metric whichtracks the replicated time as seconds since the unix epoch. The metric uses
seconds instead of nanos because the the
time()
prom function returns theseconds since the unix epoch, allowing users to easily alert if
time()-physical_replication.replicated_time_seconds
is too large.Lastly, this patch removes 2 c2c metrics that seemed useless.
Informs #113951
Release note (ui change): this patch remotes the
physical_replication.frontier_lag_nanos
metric and dbconsole graph is it'ssometimes wrong. This patch adds
physical_replication.replicated_time_seconds
metric which users may use for alerting.
Release justification: c2c metrics only change