opt: make floating-point stats calculations precise #115304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes two changes to the floating-point operators in the `adjustNullCountsForOuterJoins` statistics method: 1. The results of floating-point subtractions are adjusted to be at least `epsilon`; this avoids precision errors. 2. Calculation is avoided entirely when the result is known to be zero. This ensures an exact result in the common case when no adjustment is made to the null count estimate. This commit also reverts cockroachdb#115287, since the failing tests are now fixed. Fixes cockroachdb#115278 Release note: None
|
This change is |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
rharding6373
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
|
Build succeeded: |
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes two changes to the floating-point operators in the
adjustNullCountsForOuterJoinsstatistics method:epsilon; this avoids precision errors.This commit also reverts #115287, since the failing tests are now fixed.
Fixes #115278
Release note: None