sql: Allow unique-without-index not valid constraint in table creation #115354
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Release note (bug fix): we fixed a bug where if we add a unique-without-index-not-valid constraint to a table, then the `create_statement` from `SHOW CREATE t` is not executable and errors with "unique constraint cannot be NOT VALID". The intention here is to disallow index-backed-unique constraint and this patch fixes that.
Xiang-Gu
force-pushed
the
bug/allow-unique-without-index-not-valid-in-create-table
branch
from
519e621
to
44d218c
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @Xiang-Gu)
-- commits line 8 at r1:
I don't understand this last sentence
There was a problem hiding this comment.
Reviewable status:
Previously, rytaft (Rebecca Taft) wrote…
I don't understand this last sentence
"index-backed-unique constraint" is the usual UNIQUE constraint (implemented by creating a unique index).
UNIQUE-WITHOUT-INDEX constraint, on the other hand, is sometimes referred to as "non-index-backed-unique constraint" bc it's not implemented by a unique index.
|
TFTR! bors r+ |
Previously, Xiang-Gu (Xiang Gu) wrote…
I see, I think I was just confused about what you were disallowing. I guess the point is that you're disallowing use of NOT VALID only with index-backed unique constraints. This could probably use a bit of clarification, but not a big deal. |
|
Build failed (retrying...): |
|
Build succeeded: |
Xiang-Gu
deleted the
bug/allow-unique-without-index-not-valid-in-create-table
branch
Fixes #115352
Release note (bug fix): we fixed a bug where if we add a unique-without-index-not-valid constraint to a table, then the
create_statementfromSHOW CREATE tis not executable and errors with "unique constraint cannot be NOT VALID". The intention here is to disallow index-backed-unique constraint and this patch fixes that.