Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: ui: keep timewindow with fixed range after Now button click #115514

Merged
merged 1 commit into from Dec 4, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 3, 2023

Backport 1/1 commits from #115044 on behalf of @koorosh.

/cc @cockroachdb/release


This change fixes behavior of Now button in TimeScale component. Before, when user selected some custom time range then clicked Now button - it would not update charts because there was inconsistency. Custom time range cannot be with "moving" attribute, it cannot be updated every time to reflect most recent data as custom range has fixed end time.

This change checks if current preset is custom and doesn't set "moving" attribute in this case.

Epic: None

Resolves: #113091

Release note (ui change): proper handling of "Now" button on Time range selector when custom time period was selected before.

Screen Recording 2023-11-23 at 17 42 09 mov


Release justification: low risk, high benefit changes to existing functionality

This change fixes behavior of Now button in TimeScale component.
Before, when user selected some custom time range then clicked
Now button - it would not update charts because there was inconsistency.
Custom time range cannot be with "moving" attribute, it cannot be updated
every time to reflect most recent data as custom range has fixed end time.

This change checks if current preset is custom and doesn't set "moving"
attribute in this case.

Epic: None

Release note (ui change): proper handling of "Now" button on Time range
selector when custom time period was selected before.
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 3, 2023 12:18
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115044 branch 2 times, most recently from 8ec5e96 to 3bd3219 Compare December 3, 2023 12:18
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 3, 2023
Copy link
Author

blathers-crl bot commented Dec 3, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 3, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh merged commit afce36d into release-23.2 Dec 4, 2023
5 of 6 checks passed
@koorosh koorosh deleted the blathers/backport-release-23.2-115044 branch December 4, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants