changefeedccl: add changefeed.emitted_batch_sizes metric
#115537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jayshrivastava
requested review from
abarganier and
miretskiy
and removed request for
a team
miretskiy
reviewed
Dec 4, 2023
pkg/ccl/changefeedccl/metrics.go
Outdated
| EmittedBatchSizes: b.Histogram(metric.HistogramOptions{ | ||
| Metadata: metaChangefeedEmittedBatchSizes, | ||
| Duration: histogramWindow, | ||
| MaxVal: 1 << 24, /* 16M max batch size */ |
miretskiy
approved these changes
Dec 4, 2023
jayshrivastava
force-pushed
the
pubsub-obs
branch
2 times, most recently
from
810d668
to
0a271ad
Compare
This change introduces a new metric which is a histogram for emitted batch sizes. This metric will help debug any issues with batching when they arise. This change also introduces a new histogram window type: `DataCount16MBuckets`. It has 24 buckets from 1 - 16M, exponentially distributed. Right now, the largest batch seen by changefeeds is 670k rows (parquet with 16MB file sizes). There was no previously existing histogram bucket which would be appropriate for measuring batches of this scale. It's possible to configure larger file sizes (ex. 128MB has been used by customers before). 16M is a generous upper bound to how large batches in changefeeds may be. Release note (ops change): This change introduces the `changefeed.emitted_batch_sizes` histogram metric which measures the batch sizes used when emitting data to sinks. This metric supports metrics labels. Closes: cockroachdb#114141
jayshrivastava
force-pushed
the
pubsub-obs
branch
from
0a271ad
to
b3c4add
Compare
|
bors r=miretskiy |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new metric which is a histogram for emitted batch sizes. This metric will help debug any issues with batching when they arise.
This change also introduces a new histogram window type:
DataCount16MBuckets. It has 24 buckets from 1 - 16M, exponentially distributed. Right now, the largest batch seen by changefeeds is 670k rows (parquet with 16MB file sizes). There was no previously existing histogram bucket which would be appropriate for measuring batches of this scale. It's possible to configure larger file sizes (ex. 128MB has been used by customers before). 16M is a generous upper bound to how large batches in changefeeds may be.Release note (ops change): This change introduces the
changefeed.emitted_batch_sizeshistogram metric which measures the batch sizes used when emitting data to sinks. This metric supports metrics labels.Closes: #114141