Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: plpgsql: don't exit early when SELECT INTO returns no rows #115676

Merged
merged 1 commit into from Dec 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 6, 2023

Backport 1/1 commits from #115650 on behalf of @DrewKimball.

/cc @cockroachdb/release


Previously, a SELECT INTO statement that returned zero rows wouldn't call the continuation, since the continuation is called as a projection. This patch adds a RIGHT JOIN with a zero-column one-row Values operator to ensure that SELECT INTO statements are correctly null-extended when the underlying SQL statement returns no rows. See the postgres docs:

https://www.postgresql.org/docs/16/plpgsql-statements.html#PLPGSQL-STATEMENTS-SQL-ONEROW

Fixes #114826

Release note (bug fix): Fixed a bug that existed only in pre-release versions v23.2.0-beta.1 and v23.2.0-beta.2 which could cause PLpgSQL routines with SELECT INTO syntax to return early.


Release justification: bug fix for new functionality in 23.2

Previously, a SELECT INTO statement that returned zero rows wouldn't
call the continuation, since the continuation is called as a projection.
This patch adds a RIGHT JOIN with a zero-column one-row Values operator
to ensure that SELECT INTO statements are correctly null-extended when
the underlying SQL statement returns no rows. See the postgres docs:
```
https://www.postgresql.org/docs/16/plpgsql-statements.html#PLPGSQL-STATEMENTS-SQL-ONEROW
```

Fixes #114826

Release note (bug fix): Fixed a bug that existed only in pre-release
versions v23.2.0-beta.1 and v23.2.0-beta.2 which could cause PLpgSQL
routines with SELECT INTO syntax to return early.
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 6, 2023 02:59
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115650 branch from 96abcb2 to 3931753 Compare December 6, 2023 02:59
@blathers-crl blathers-crl bot requested review from rharding6373 and removed request for a team December 6, 2023 02:59
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 6, 2023
Copy link
Author

blathers-crl bot commented Dec 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 6, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @rharding6373)

@yuzefovich
Copy link
Member

Merging since backport of #115657 needs to be on top of this.

@yuzefovich yuzefovich merged commit fcd4168 into release-23.2 Dec 6, 2023
5 of 6 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-23.2-115650 branch December 6, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants