Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "s3: disable content pre-upload checksums" #115713

Merged
merged 1 commit into from Dec 6, 2023

Conversation

adityamaru
Copy link
Contributor

@adityamaru adityamaru commented Dec 6, 2023

This reverts commit 50c453a.

Release note (bug fix): fixes a regression that causes uploads to object locked buckets to fail because of the absence of an MD5 hash

Informs: #115602

This reverts commit 50c453a.

Release note (bug fix): fixes a regression that causes uploads
to object locked buckets to fail because of the absence of an MD5 hash
@adityamaru adityamaru requested a review from a team as a code owner December 6, 2023 18:17
Copy link

blathers-crl bot commented Dec 6, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

bors r=stevendanna

@craig
Copy link
Contributor

craig bot commented Dec 6, 2023

Build succeeded:

@craig craig bot merged commit 315c305 into cockroachdb:master Dec 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants