release-23.2: ttljob: introduce sql.ttl.default_select_rate_limit cluster setting, ttl_select_rate_limit storage param #115801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These structs contain parameters for SelectQueryBuilder and DeleteQueryBuilder. The *Params structs reduce number of params that need to be kept in sync between the Make*QueryBuilder functions and the *QueryBuilder structs. Release note: None
…eryBounds By creating these structs at a higher level and passing them into runTTLOnQueryBounds, runTTLOnQueryBounds needs fewer params to create these structs itself. Release note: None
…ttl_select_rate_limit storage param Fixes cockroachdb#110742 Release note (sql change): Add sql.ttl.default_select_rate_limit cluster setting and ttl_select_rate_limit table storage param to set TTL select rate limit. This sets the number of records per table per second per node that can be selected by the TTL job.
|
This change is |
rafiss
changed the title
rafiss
changed the title
andyyang890
approved these changes
Dec 8, 2023
|
|
||
| aostDuration := ttlSpec.AOSTDuration | ||
| if aostDuration == 0 { | ||
| // Read AOST in case of mixed 22.2.0/22.2.1+ cluster where the job started on a 22.2.0 node. |
There was a problem hiding this comment.
Same question as on the release-23.2.0-rc backport PR, should this code remain based on #101119 (review)?
There was a problem hiding this comment.
good question, but no, we decided not to support version skipping from 22.2 directly to 23.2: cockroachlabs.slack.com/archives/C05B1BPMJLE/p1696908185131109?thread_ts=1696898969.397849&cid=C05B1BPMJLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #112119.
/cc @cockroachdb/release
Release justification: important feature that can't be backported later
Fixes #110742
Add sql.ttl.default_select_rate_limit cluster setting and ttl_select_rate_limit table storage param to set TTL select rate limit. This sets the number of records per table per second per node that can be selected by the TTL job.