Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: sql: prevent creating indexes on arrays of non-indexable types #116071

Merged
merged 1 commit into from Dec 26, 2023

Conversation

chrisseto
Copy link
Contributor

@chrisseto chrisseto commented Dec 11, 2023

Backport 1/1 commits from #115707.

/cc @cockroachdb/release


ae7fbfb sql: prevent creating indexes on arrays of non-indexable types

Previously, it was possible to circumvent the check performed by
ColumnTypeIsIndexable and ColumnTypeIsInvertedIndexable by wrapping
a type in an array. Doing so would violate some invariants across the
system and lead to undefined behavior.

This commit updates both ColumnTypeIsIndexable and
ColumnTypeIsInvertedIndexable to unwrap array types, as necessary, to
prevent invalid indexes from being created.

Fixes: #115701
Epic: none
Release note (bug fix): Standard and inverted indexes may no longer be
created on REFCURSOR[]s columns. REFCURSOR columns themselves are not
indexable.
Release justification: Prevents users from creating invalid indexes and is otherwise minimally invasive.

Previously, it was possible to circumvent the check performed by
`ColumnTypeIsIndexable` and `ColumnTypeIsInvertedIndexable` by wrapping
a type in an array. Doing so would violate some invariants across the
system and lead to undefined behavior.

This commit updates both `ColumnTypeIsIndexable` and
`ColumnTypeIsInvertedIndexable` to unwrap array types, as necessary, to
prevent invalid indexes from being created.

Fixes: cockroachdb#115701
Epic: none
Release note (bug fix): Standard and inverted indexes may no longer be
created on REFCURSOR[]s columns. REFCURSOR columns themselves are not
indexable.
Copy link

blathers-crl bot commented Dec 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@chrisseto chrisseto marked this pull request as ready for review December 11, 2023 16:31
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 11, 2023
@chrisseto chrisseto requested a review from a team as a code owner December 11, 2023 16:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @rafiss)

@rafiss rafiss merged commit 4ac5719 into cockroachdb:release-23.2 Dec 26, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants