release-23.2: sql: prevent creating indexes on arrays of non-indexable types #116071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #115707.
/cc @cockroachdb/release
ae7fbfb sql: prevent creating indexes on arrays of non-indexable types
Previously, it was possible to circumvent the check performed by
ColumnTypeIsIndexable
andColumnTypeIsInvertedIndexable
by wrappinga type in an array. Doing so would violate some invariants across the
system and lead to undefined behavior.
This commit updates both
ColumnTypeIsIndexable
andColumnTypeIsInvertedIndexable
to unwrap array types, as necessary, toprevent invalid indexes from being created.
Fixes: #115701
Epic: none
Release note (bug fix): Standard and inverted indexes may no longer be
created on REFCURSOR[]s columns. REFCURSOR columns themselves are not
indexable.
Release justification: Prevents users from creating invalid indexes and is otherwise minimally invasive.