Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgwirecancel: deflake TestCancelCopyTo #116072

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 11, 2023

This test had a race condition since it used the same err variable in different goroutines.

fixes #116032
Release note: None

This test had a race condition since it used the same err variable in
different goroutines.

Release note: None
@rafiss rafiss added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Dec 11, 2023
@rafiss rafiss requested a review from annrpom December 11, 2023 16:34
@rafiss rafiss requested review from a team as code owners December 11, 2023 16:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @annrpom)

@rafiss
Copy link
Collaborator Author

rafiss commented Dec 11, 2023

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 11, 2023

Build succeeded:

@craig craig bot merged commit 4bdde4c into cockroachdb:master Dec 11, 2023
9 checks passed
Copy link

blathers-crl bot commented Dec 11, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-116072 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/116077/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-23.2-116072 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/116078/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rafiss rafiss deleted the deflake-TestCancelCopyTo branch December 13, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/pgwire/pgwirecancel: TestCancelCopyTo failed
3 participants