Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2.0-rc: pcr: extend retries to a few minutes #116404

Merged
merged 2 commits into from Dec 16, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 13, 2023

Backport 2/2 commits from #116341 on behalf of @dt.

/cc @cockroachdb/release


Previously we'd only retry for 20us but that is likely too short for most
network issues to resolve themselves.

Release note (enterprise change): PCR now retries for just over 3 minutes before failing.
Epic: none.


Release justification:

Previously we'd only retry for 20us but that is likely too short for most
network issues to resolve themselves.

Release note (enterprise change): PCR now retries for just over 3 minutes before failing.
Epic: none.
Previously it implied it was waiting even when it had resumed the retry.

Release note: none.
Epic: none.
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 13, 2023 22:46
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2.0-rc-116341 branch from b237f62 to c5e2e1e Compare December 13, 2023 22:46
@blathers-crl blathers-crl bot requested review from adityamaru and removed request for a team December 13, 2023 22:46
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 13, 2023
Copy link
Author

blathers-crl bot commented Dec 13, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 13, 2023
Copy link
Author

blathers-crl bot commented Dec 13, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt merged commit 12a0dd6 into release-23.2.0-rc Dec 16, 2023
4 of 6 checks passed
@dt dt deleted the blathers/backport-release-23.2.0-rc-116341 branch December 16, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants