New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: sql: support sequence and udt name rewriting in plpgsql #116419
release-23.2: sql: support sequence and udt name rewriting in plpgsql #116419
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Needs #116423 as a prereq. |
Adding @rafiss as second TL reviewer |
310e20c
to
a0a61b8
Compare
CRDB rewrites sequence and UDT names as IDs in views and functions so that if the sequence or UDT is renamed the views and functions using them don't break. This PR adds support for this in PLpgSQL. Epic: None Fixes: cockroachdb#115627 Release note (sql change): Fixes a bug in PLpgSQL where altering the name of a sequence or UDT that was used in a PLpgSQL function or procedure could break them. This is only present in 23.2 alpha and beta releases.
a0a61b8
to
33d6c2d
Compare
TFTRs! |
Backport 1/1 commits from #115809.
/cc @cockroachdb/release
CRDB rewrites sequence and UDT names as IDs in views and functions so
that if the sequence or UDT is renamed the views and functions using
them don't break. This PR adds support for this in PLpgSQL.
Epic: None
Fixes: #115627
Release note: Fixes a bug in PLpgSQL where altering the name of a
sequence or UDT that was used in a PLpgSQL function or procedure could
break them. This is only present in 23.2 alpha and beta releases.
Release justification: Fixes a bug in PLpgSQL that could result in breaking PLpgSQL functions if sequences or UDTs are renamed.