Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: ui: remove "undefined" from events description #116518

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 15, 2023

Backport 1/1 commits from #116496 on behalf of @maryliag.

/cc @cockroachdb/release


Fixes #116491

Not all types of schema changes are setting the value for the mudation ID, causing the value to show as undefined on the UI.
This commit checks if the value exists to be displayed, otherwise don't show it.

Before
Screenshot 2023-12-14 at 4 18 43 PM

After
Screenshot 2023-12-14 at 4 37 06 PM

Release note (bug fix): Remove ID from event description when is undefined.


Release justification: bug fix

Fixes #116491

Not all types of schema changes are setting the value for
the mudation ID, causing the value to show as `undefined` on
the UI.
This commit checks if the value exists to be displayed,
otherwise don't show it.

Release note (bug fix): Remove ID from event description when
is `undefined`.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-116496 branch from 03b065d to 7671e03 Compare December 15, 2023 02:32
@blathers-crl blathers-crl bot requested a review from a team December 15, 2023 02:32
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 15, 2023
Copy link
Author

blathers-crl bot commented Dec 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from fqazi December 15, 2023 02:32
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 15, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag merged commit ff49d35 into release-23.2 Dec 18, 2023
5 of 6 checks passed
@maryliag maryliag deleted the blathers/backport-release-23.2-116496 branch December 18, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants