Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: go.mod: bump Pebble to 78ab2ba86c80 #116560

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Dec 15, 2023

78ab2ba8 db: use uncompensated scores to prioritize levels for compaction
d8c39c30 Makefile: update crossversion-meta to test 22.2 -> 23.1 only
8cdfebc8 sstable: fix two-level iterator NextPrefix error propagation

Epic: none
Release note (bug fix): This commit reduces the impact of bulk deletions (DROP TABLEs, TRUNCATE TABLEs, or replica removals) on foreground traffic by altering storage engine compaction priorities.
Release justification: Mitigation against a common source of overload and cluster unavailability.

```
78ab2ba8 db: use uncompensated scores to prioritize levels for compaction
d8c39c30 Makefile: update crossversion-meta to test 22.2 -> 23.1 only
8cdfebc8 sstable: fix two-level iterator NextPrefix error propagation
```

Epic: none
Release note (bug fix): This commit reduces the impact of bulk deletions (DROP
TABLEs, TRUNCATE TABLEs, or replica removals) on foreground traffic by altering
storage engine compaction priorities.
@jbowens jbowens requested review from a team and aadityasondhi December 15, 2023 17:16
@jbowens jbowens requested a review from a team as a code owner December 15, 2023 17:16
Copy link

blathers-crl bot commented Dec 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 15, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi)

@jbowens
Copy link
Collaborator Author

jbowens commented Jan 18, 2024

TFTRs!

@jbowens jbowens merged commit bdcc2cc into cockroachdb:release-23.1 Jan 18, 2024
6 checks passed
@jbowens jbowens deleted the jackson/pebble-release-23.1-78ab2ba86c80 branch January 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants