sql/contention: turn on sql.contention.record_serialization_conflicts… #116664
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
xinhaoz
requested review from
maryliag,
koorosh,
a team and
abarganier
and removed request for
a team
There was a problem hiding this comment.
does this turn on certain collections (e.g. traces) that it wouldn't with the setting off? Curious if turning on by default can cause performance degradation
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @abarganier and @koorosh)
xinhaoz
force-pushed
the
turn-on-serialization-conflict-recording
branch
2 times, most recently
from
c61dbe5
to
bc99527
Compare
There was a problem hiding this comment.
@maryliag No, it just allows the information to be recorded by the contention registry when it is available.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
….enabled Turn on sql.contention.record_serialization_conflicts.enabled by default and make this setting public. Release note (ops change): The cluster setting sql.contention.record_serialization_conflicts.enabled is now on by default. This means any 40001 errors that are returned containing conflicting transaction information will be recorded by the contention registry. Closes: cockroachdb#114416
xinhaoz
force-pushed
the
turn-on-serialization-conflict-recording
branch
from
bc99527
to
288a52d
Compare
|
bors r+ |
|
Build succeeded: |
….enabled
Turn on sql.contention.record_serialization_conflicts.enabled by default and make this setting public.
Release note (ops change): The cluster setting
sql.contention.record_serialization_conflicts.enabled is now on by default. This means any 40001 errors that are returned containing conflicting transaction information will be recorded by the contention registry.